Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit coverage for component TraceIDSearchInput #616

Merged
merged 2 commits into from
Aug 12, 2020

Conversation

tklever
Copy link
Contributor

@tklever tklever commented Aug 12, 2020

Which problem is this PR solving?

  • TraceIDSearchInput had a lack of coverage, this PR sets out to solve that.

Short description of the changes

  • Added additional tests around the existing functionality of TraceIDSearchInput

Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com>
@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #616 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #616      +/-   ##
==========================================
+ Coverage   92.70%   92.77%   +0.06%     
==========================================
  Files         227      227              
  Lines        5911     5911              
  Branches     1491     1491              
==========================================
+ Hits         5480     5484       +4     
+ Misses        390      386       -4     
  Partials       41       41              
Impacted Files Coverage Δ
...eViewer/TimelineHeaderRow/TimelineViewingLayer.tsx 88.13% <0.00%> (-3.39%) ⬇️
...aeger-ui/src/components/App/TraceIDSearchInput.tsx 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6340b9a...c0e189d. Read the comment docs.

Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com>
@yurishkuro yurishkuro merged commit aa096b0 into jaegertracing:master Aug 12, 2020
@tklever tklever deleted the tests-TraceIDSearchInput branch August 12, 2020 18:36
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
* add unit coverage for component TraceIDSearchInput

Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com>

* Correct copyright holder

Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com>

Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
* add unit coverage for component TraceIDSearchInput

Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com>

* Correct copyright holder

Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com>

Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
* add unit coverage for component TraceIDSearchInput

Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com>

* Correct copyright holder

Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com>

Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants